Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify some log level. #1351

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Modify some log level. #1351

merged 5 commits into from
Dec 3, 2019

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Nov 28, 2019

  1. Modify some logs level in MetaClient, Raft, NebulaStore.
  2. Fix raft_case_test.

close #1271, close #1347.

We need to adjust all logs level later after we have some log level principle.

@yixinglu
Copy link
Contributor

reference #1271

darionyaphet
darionyaphet previously approved these changes Nov 28, 2019
Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebula-community-bot
Copy link
Member

Unit testing passed.

laura-ding
laura-ding previously approved these changes Nov 28, 2019
monadbobo
monadbobo previously approved these changes Nov 29, 2019
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/kvstore/NebulaStore.cpp Outdated Show resolved Hide resolved
src/kvstore/NebulaStore.cpp Outdated Show resolved Hide resolved
src/kvstore/raftex/RaftPart.cpp Show resolved Hide resolved
src/kvstore/raftex/RaftPart.cpp Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit 9b6baac into vesoft-inc:master Dec 3, 2019
@critical27 critical27 deleted the log branch December 3, 2019 08:13
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* fix raft case test

* modify some log level

* address @dangleptr's comments

* address @dangleptr's comments
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed UT: 46 - raft_case_test (Failed) Output too many duplicate logs when minloglevel is INFO
7 participants